Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to some ultra ancient sprites #5678

Merged
merged 13 commits into from
Feb 18, 2024

Conversation

Blundir
Copy link
Contributor

@Blundir Blundir commented Feb 7, 2024

About the pull request

This pr aims to update/correct sprites that look like this:

Example

StrongDMM_j51KDPeYYU
StrongDMM_8kBEwLWHKn
StrongDMM_vCmcme098x
StrongDMM_YcpXSx2Csu
StrongDMM_x8ze6bT0Ye
StrongDMM_PkvyE8FMPW
StrongDMM_mjvY3r7nMT
StrongDMM_WoHe9doCda
StrongDMM_xWgkCF5uC3
StrongDMM_IFnTgcGcUY
StrongDMM_OlOJTtvvhL
dreammaker_MVtobf4dvv

Such sprites are very very old, pre cm era most of them, some of which weren't updated for 12+ years.

Most of updated sprites were taken from TGMC, others from Baystation, Aurora and TG, all credits to them, remaining sprites were made by me.

To see full list of what i've updated, see icondiffbot changes.

Explain why it's good for the game

Less fossilized stuff.

Testing Photographs and Procedure

Screenshots & Videos

StrongDMM_u5OswblCBx
StrongDMM_1UHx0NK8Q6
StrongDMM_rbth5mZSWJ
StrongDMM_Mp66s8sWGx
StrongDMM_ceEEajlHNZ
StrongDMM_uIVfaqHsGd
StrongDMM_FikQODdmRy
StrongDMM_hH03QCpTJR
StrongDMM_U3Jb51Gcs0
StrongDMM_wczgnQ89oE
StrongDMM_M09Y0daC8u
dreammaker_MmtlKcPWIk

Changelog

🆑
imageadd: updated many old/legacy sprites
/:cl:

@Blundir Blundir requested a review from Nanu308 as a code owner February 7, 2024 10:04
@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? labels Feb 7, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapping lgtm

@Nanu308
Copy link
Member

Nanu308 commented Feb 7, 2024

I see you mention porting some sprites, have you made sure to update them to CMs style / standard regarding sprites?

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Feb 7, 2024
@Blundir
Copy link
Contributor Author

Blundir commented Feb 7, 2024

I see you mention porting some sprites, have you made sure to update them to CMs style / standard regarding sprites?

I've reused many cm sprites here, the sprites I took from tgmc are CM stylized, they were made in early tgmc era, about other sprites, they look passing, especially compared to their current counterpart, I've included a comparison, in case you didn't notice.

Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to see someone helping chip away at legacy sprites. approved 👍

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label Feb 18, 2024
@sleepynecrons sleepynecrons added this pull request to the merge queue Feb 18, 2024
Merged via the queue into cmss13-devs:master with commit 71d46ee Feb 18, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants